This project is read-only.

Castle.Core Pull request...

Oct 12, 2010 at 12:33 AM

Not sure who denied a pull request for Castle.Core 2.5.1, but it was based on the request for NLog and log4net dependencies to be included in the package.  Those are optional dependencies only if you are using those loggin frameworks and only if you want Castle.Core to log output.  I've pulled the assemblies themselves out (my mistake), but making them dependencies seems a bit presumptuous.  It's possible you could make those dependencies a seperate package (ie Castle.Core NLog Integration)

Thoughts?

Oct 12, 2010 at 12:38 AM

It was me, doesn't it say in the notification email?  I'll start including my name in there.

That does raise an interesting topic.  Would you mind reposting on http://nupack.codeplex.com?  I think that very few people are following discussions on nupackpackages, so we can get more traction there.

Oct 12, 2010 at 12:55 AM

I think it was for my previous denial on observal:), but not this one.  No biggy.  Codeplex pull requests have a long ways to go in the end-to-end experience.

NUpack thread: http://nupack.codeplex.com/Thread/View.aspx?ThreadId=230498

 

Oct 12, 2010 at 12:58 AM

Thanks.  BTW, I have no problem getting your package in the feed while we have the discussion on the right way to do dependencies (on the other forum).  We're really not trying to police the feed, but if I see something that seems wrong and could have be done by mistake, I just let the owner know.

Oct 12, 2010 at 1:16 AM

I've added the dependencies in there to be consistent for now.  We can commit to something later and update the package.  I'll create another pull request for the latest with dependencies.